Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various modules: importing global to get version #11837

Closed
patmmccann opened this issue Jun 20, 2024 · 2 comments · Fixed by #11836
Closed

Various modules: importing global to get version #11837

patmmccann opened this issue Jun 20, 2024 · 2 comments · Fixed by #11836

Comments

@patmmccann
Copy link
Collaborator

Type of issue

Bug

Description

https://github.com/search?q=repo%3Aprebid%2FPrebid.js+getglobal%28%29.version+path%3A%2F%5Emodules%5C%2F%2F&type=code

Should just use '$prebid.version$'

Steps to reproduce

Test page

Expected results

Actual results

Platform details

Other information
@dgirardi
Copy link
Collaborator

I think using getGlobal is better. If we ever get to #5287, part of it would be to reduce or get rid of these macros - they only work if you use our build.

@patmmccann patmmccann mentioned this issue Jun 20, 2024
Merged
10 tasks
@patmmccann
Copy link
Collaborator Author

176 adapters use the macro; seems wise to save a bit of complexity in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various modules: don't import global to get version prebid/Prebid.js
2 participants
@patmmccann @dgirardi