Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent outer spacing between components #248

Open
sergioalvz opened this issue Apr 25, 2023 · 3 comments
Open

Inconsistent outer spacing between components #248

sergioalvz opened this issue Apr 25, 2023 · 3 comments
Labels

Comments

@sergioalvz
Copy link

Hey folks 馃憢,

I see there are some inconsistencies in components about horizontal spacing. That's especially noticeable when looking at components in narrow screen sizes. For example, the SectionIntro component uses a padding-block property that makes it have some horizontal space in narrow screens, while the River or the FAQ, for example, will be touching the screen's borders.

Right now, I'm applying some custom padding for both River and FAQ to create a consistent experience, but I think it would be great if we could make all components behave the same.

@rezrah rezrah added the brand label Apr 25, 2023
@rezrah
Copy link
Collaborator

rezrah commented May 2, 2023

Primer Brand maintainers will follow up on this by performing an audit of existing components that contain internal padding, with a view to replace with new Grid component.

@josepmartins
Copy link
Contributor

josepmartins commented May 9, 2023

Adding more examples, this time about managing vertical spacing:

Slack thread: https://github.slack.com/archives/C04E44ZPNEA/p1683546014522099

@josepmartins josepmartins changed the title Inconsistent horizontal spacing between components Inconsistent outer spacing between components May 9, 2023
@sergioalvz
Copy link
Author

Adding one more example. The River component ensures some outer spacing, but Testimonial and FAQ components do not work well together without additional CSS:

Screenshot 2023-05-16 at 11 00 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants