Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lookup argument creation #267

Closed
alxkzmn opened this issue Jul 8, 2024 · 0 comments
Closed

Refactor lookup argument creation #267

alxkzmn opened this issue Jul 8, 2024 · 0 comments
Assignees

Comments

@alxkzmn
Copy link
Collaborator

alxkzmn commented Jul 8, 2024

Currently, if the lookup-any-sanity-checks feature in recent Halo2 is not disabled, our circuits will fail it (https://github.com/privacy-scaling-explorations/halo2/blob/bc857a701715ac3608056cb9b1999ad7cbc00b59/halo2_frontend/src/plonk/circuit/constraint_system.rs#L441). As follows from the sanity check, the reason is that all our table expressions contain only fixed query and should use lookup API instead of `lookup_any. (https://github.com/privacy-scaling-explorations/chiquito/blob/255-compile-to-halo2-middleware/src/plonkish/backend/halo2.rs#L250-L251)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant