Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add reachable peers to the routing table #53

Closed
Tracked by #54
guillaumemichel opened this issue Jul 6, 2023 · 2 comments
Closed
Tracked by #54

Only add reachable peers to the routing table #53

guillaumemichel opened this issue Jul 6, 2023 · 2 comments
Labels
scope/nicetohave Nice to have feature going beyond go-libp2p-kad-dht

Comments

@guillaumemichel
Copy link
Contributor

Ensure that we only add nodes that are actually able to answer our Kademlia requests to the routing table. When refreshing the routing table, we should make sure that the nodes still answer Kademlia requests correctly.

In the IPFS KadDHT, this check can be done by sending a Kademlia GET_PROVIDERS or FIND_NODE RPC, and if the probed peer provides a valid response we can add/keep it in the routing table.

References
@guillaumemichel guillaumemichel added the scope/nicetohave Nice to have feature going beyond go-libp2p-kad-dht label Jul 6, 2023
@guillaumemichel guillaumemichel mentioned this issue Jul 6, 2023
Open
19 tasks
@iand
Copy link
Contributor

iand commented Aug 11, 2023

This is covered by the design for the candidate queue in #45

@iand
Copy link
Contributor

iand commented Sep 19, 2023

Done

@iand iand closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope/nicetohave Nice to have feature going beyond go-libp2p-kad-dht
Projects
DHT Optimization
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iand @dennis-tra @guillaumemichel