Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization support #11

Closed
Lacyway opened this issue Apr 29, 2024 · 4 comments
Closed

Add localization support #11

Lacyway opened this issue Apr 29, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Lacyway
Copy link
Member

Lacyway commented Apr 29, 2024

Retrieve data from server?

@DeadLeavez
Copy link
Contributor

DeadLeavez commented Apr 29, 2024

Im assuming you mean for the F12 interface. No other mods do localization as far as I know. But that shouldn't stop us if it's something we want. I don't think grabbing from the server is a good idea though, seems unnecessarily complex and causes unnecessary network traffic. Could be stored in files next to the .dll.

I think we should follow the practice of many other mods to have .dll in it's own folder inside of bepinex/plugins. It might not do anything right now, but it would allow us to do things like add localization files, or any sort of files to the plugin project without changing file-tree structure in the future. And we've the perfect opportunity to do so now that we're also renaming and rebranding in the same swoop.

@Lacyway
Copy link
Member Author

Lacyway commented Apr 29, 2024

I don't think downloading the lang files would be too slow, it's already in the assets folder ready to go, we never finalized it. Sending raw data without generating it is fast.

The point was to automatically detect the chosen language (so no F12 setting) and download the corresponding file and use those variables, this is what the server mod is ready for. Or we store it in the client and read from file as you said.

@MerijnHendriks @TheSpartaPT what would be your preferred route?

Edit: forgot to mention that this is for everywhere in the mod where we display text, so not just in the F12 menu. I misunderstood your message.

@DeadLeavez
Copy link
Contributor

If there are stuff in the server that need localization too, then it might be worth putting it there indeed.

@Lacyway Lacyway added the enhancement New feature or request label May 2, 2024
@MerijnHendriks
Copy link
Contributor

I prefer if we downloaded it from the server. Makes modding easier and allows for faster updates to i18n if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants