Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix st nil ptr deref #1140

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix st nil ptr deref #1140

merged 1 commit into from
Jan 31, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1139

@dogancanbakir dogancanbakir self-assigned this Jan 29, 2024
Mzack9999
Mzack9999 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - It seems like that the only case in which resp != nil and err != nil is https://golang.org/issue/3795

@ehsandeep ehsandeep merged commit cddc3cf into dev Jan 31, 2024
8 checks passed
@ehsandeep ehsandeep deleted the fix_st_nil_ptr_deref branch January 31, 2024 16:41
@GDATTACKER-RESEARCHER
Copy link

still after update

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x108ee79]

goroutine 148 [running]:
github.com/projectdiscovery/subfinder/v2/pkg/subscraping/sources/securitytrails.(*Source).Run.func1()
/root/go/pkg/mod/github.com/projectdiscovery/subfinder/[email protected]/pkg/subscraping/sources/securitytrails/securitytrails.go:69 +0x499
created by github.com/projectdiscovery/subfinder/v2/pkg/subscraping/sources/securitytrails.(*Source).Run in goroutine 104
/root/go/pkg/mod/github.com/projectdiscovery/subfinder/[email protected]/pkg/subscraping/sources/securitytrails/securitytrails.go:42 +0x10f

@dogancanbakir
Copy link
Member Author

@GDATTACKER-RESEARCHER , This fix will be in the next release -you're still using the previous version.

@BrewTestBot BrewTestBot mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x10838d9]
4 participants
@dogancanbakir @GDATTACKER-RESEARCHER @ehsandeep @Mzack9999