Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove time.sleep from sources #1175

Merged
merged 4 commits into from
Mar 15, 2024
Merged

remove time.sleep from sources #1175

merged 4 commits into from
Mar 15, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1174

@dogancanbakir dogancanbakir self-assigned this Feb 29, 2024
@dogancanbakir dogancanbakir changed the title remove time.sleep from sitedossier remove time.sleep from sources Feb 29, 2024
@dogancanbakir dogancanbakir marked this pull request as ready for review February 29, 2024 21:30
Mzack9999
Mzack9999 reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to double check if this update is due to server side loosening of rate limits (for example GH has still the same rate limits of implementation time)

@dogancanbakir
Copy link
Member Author

I believe that before #891, we were trying to limit the requests with time.Sleep. Since we now have this feature, we no longer need those. So, this PR simply removes them and, if necessary, adds default rate limits for sources.

@ehsandeep ehsandeep merged commit 3a52a8e into dev Mar 15, 2024
8 checks passed
@ehsandeep ehsandeep deleted the remove_time_sleep branch March 15, 2024 16:27
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove time.sleep from sources
3 participants
@dogancanbakir @ehsandeep @Mzack9999