Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for passivetotal #942

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Add warning for passivetotal #942

merged 4 commits into from
Sep 12, 2023

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Aug 16, 2023

Closes #920.

Note: After reviewing again, we found that the old users can still generate API credentials which they can use for PassiveTotal source, but the same wasn't possible with the new users. I updated the PR by adding a warning to inform users of this.

@dogancanbakir dogancanbakir self-assigned this Aug 16, 2023
@dogancanbakir dogancanbakir changed the base branch from main to dev August 16, 2023 13:07
@dogancanbakir dogancanbakir changed the title Disable passivetotal Add warning for passivetotal Aug 17, 2023
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggesting minor improvement

v2/pkg/passive/sources.go Outdated Show resolved Hide resolved
v2/pkg/passive/sources.go Outdated Show resolved Hide resolved
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Aug 23, 2023
@ehsandeep ehsandeep merged commit 689a687 into dev Sep 12, 2023
8 checks passed
@ehsandeep ehsandeep deleted the disable_passivetotal branch September 12, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PassiveTotal api no longer works
3 participants