Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use -shortmode for excluding long running tests #948

Merged
merged 2 commits into from
Aug 29, 2023
Merged

use -shortmode for excluding long running tests #948

merged 2 commits into from
Aug 29, 2023

Conversation

dogancanbakir
Copy link
Member

Proposed Solution:

  1. Consider segregating tests related to problematic APIs into a separate GitHub Action.
  2. Implement an environment variable to toggle these tests on/off, ensuring core tests run smoothly.

Closes #946.

@dogancanbakir dogancanbakir self-assigned this Aug 21, 2023
@dogancanbakir dogancanbakir linked an issue Aug 21, 2023 that may be closed by this pull request
Integration Test Failures Due to Sources #946
Closed
@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Aug 29, 2023
Mzack9999
Mzack9999 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - https://github.com/projectdiscovery/subfinder/actions/runs/6008478074

@Mzack9999 Mzack9999 merged commit 36d102b into dev Aug 29, 2023
11 checks passed
@Mzack9999 Mzack9999 deleted the use_short_for_long_tests branch August 29, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration Test Failures Due to Sources
2 participants
@dogancanbakir @Mzack9999