-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose to build and publish protobuf-v3.0.0-javalite for ARM platform to Maven central #6867
Comments
@liusheng, I mentioned that upgrading javalite could help at grpc/grpc-java#6364 (comment) . @rafi-kamal, I was waiting to upgrade until #6565 had documentation on how to workaround, like we had talked about a few months ago. Although now I'm also trying to remember if it was appropriate to use the pre-compiled protoc from the master branch with javalite even though javalite is on its own branch, since that's the only pre-built binary available https://search.maven.org/search?q=g:com.google.protobuf . We had discussed that at the same time, but in the months since I've forgotten what was decided. |
That issue should have been fixed in the 3.10 release :) We are also planning to do a 3.11 release next week.
Is it possible to use the regular protoc instead? According to https://github.com/protocolbuffers/protobuf/blob/master/java/lite.md, that should be enough to generate the lite version of the messages. |
Do you want to close the issue then?
That's what I was asking. This is what I had tried before and "it worked" but I wasn't certain it was correct. So the lite generated code is maintained on the master branch, but the runtime is on the javalite branch. |
Sorry for the confusion, the original authors are not around so I'm also not totally sure about the history behind the javalite branch. But that branch is no longer actively maintained, and we've been publishing all the new changes to master and also releasing [protobuf-javalite] (https://mvnrepository.com/artifact/com.google.protobuf/protobuf-javalite) from master. So I think If there is anything missing from master and only available in javalite, please let me know. |
Hmmm... So gradle/maven central is working. But it seems Bazel isn't ready on master. I don't see a javalite_toolchain, which is depended on implicitly by java_lite_proto_library rules. So I don't think any bazel users have swapped to the master branch for javalite, unless that is no longer how it is done. This is on the javalite branch: Lines 871 to 877 in 7b64714
|
Do you want me to create a PR with this rule? Note that we freezed the master branch until the next release for Code Yellow (the release is going to happen sometime next week). |
@rafi-kamal, that would be really nice. But it would need to more closely match the cpp/java_toolchain and should really be tested at least once. |
Hi @rafi-kamal @ejona86, Thanks you :-) |
What language does this apply to?
NA
Describe the problem you are trying to solve.
Currently, the
protoc-gen-javalite:3.0
has published in the maven central repo, it supportlinux_x86
,osx_x86
,windows_x86
system types, but didn't support theARM64
platform. When build some project such asgrpc-java
which depend on theprotoc-gen-javalite:3.0
on ARM64 server, it will raise error:Describe the solution you'd like
It doesn't need to modify anything, only need to build on ARM64 server and published to maven central repo.
Describe alternatives you've considered
Build manually every time
Additional context
NA
The text was updated successfully, but these errors were encountered: