Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't have a Custom Crop profile #5

Closed
MattieX opened this issue Jun 7, 2020 · 2 comments
Closed

Can't have a Custom Crop profile #5

MattieX opened this issue Jun 7, 2020 · 2 comments
Assignees
Labels
bug Something isn't working shortcuts
Milestone

Comments

@MattieX
Copy link

MattieX commented Jun 7, 2020

  • Chrome Version: 83.0.4103.97
  • Plugin Version: Latest
  • Monitor resolution: 2560x1080
  • Operating System: Windows 10

Expected Behavior

To remember the pre-defined User Crop setting

Actual Behavior

When toggling away from the Force Crop/Zoom Mode, e.g. back to 16:9 you will lose the Custom Crop settings which for me is 16:9, Cropped and Zoomed to 21:9 so 1.33 Width and 1.33 Height. Changing back to 16:9 sets this to 1 Width and 1 Height, as the previous settings aren't remembered, you have to manually set them again

Steps to Reproduce

  1. Set a keybind for 16:9 and force Crop + Zoom Mode
  2. In GUI select 21:9 and then Crop + Zoom
  3. Press the 16:9 Shortcut and refresh the page, observe the ratio is set to 1:1. Pressing the crop + zoom mode is not remembered. It will just stretch to 21:9 so everything looks out of proportion
@ptkdev ptkdev self-assigned this Jun 7, 2020
@ptkdev ptkdev added bug Something isn't working enhancement New feature or request labels Jun 7, 2020
@ptkdev ptkdev added this to the v1.6.0 milestone Jun 7, 2020
@ptkdev ptkdev added shortcuts and removed enhancement New feature or request labels Jun 7, 2020
@ptkdev
Copy link
Owner

ptkdev commented Jun 7, 2020

Thank's for reporting! I checked and you're right, i try add fix in next release.

@ptkdev ptkdev modified the milestones: v1.6.0, v1.5.2 Oct 24, 2020
@ptkdev
Copy link
Owner

ptkdev commented Oct 24, 2020

Available in v1.5.2

@ptkdev ptkdev closed this as completed Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shortcuts
Projects
None yet
Development

No branches or pull requests

2 participants