valid_default_lang error occurring for gtfs feeds.

[rahulkgupta]

ERROR: new row for relation "feed_info" violates check constraint "valid_default_lang"

Was fixed by changing feed_lang from en to en_US.utf8 but en seems to be used in the example amtrak GTFS and in BART.

[derhuerst]

AFAICT, en is a valid BCP 47 language tag, so it should not cause gtfs-via-postgres to fail.

This is the current implementation of the validation:

gtfs-via-postgres/lib/prerequisites.js

Lines 5 to 22 in 6a022f2

	-- Unfortunately information_schema.collations.collation_name only has
	-- identifiers with "_", not with "-", so we use pg_collation instead.
	-- https://www.postgresql.org/docs/current/infoschema-collations.html
	-- https://www.postgresql.org/docs/current/catalog-pg-collation.html
	CREATE OR REPLACE FUNCTION "${opt.schema}".is_bcp_47_code(
	input TEXT
	)
	RETURNS BOOLEAN
	AS $$
	SELECT EXISTS (
	SELECT collctype
	FROM pg_collation
	WHERE collctype = input
	OR collname = input
	OR collname = input || '-x-icu'
	LIMIT 1
	);
	$$ language sql STABLE;

I'm not that familiar though, with the details of how PostgreSQL handles localisation, so I don't know how to implement this properly.

[1Maxnet1]

FYI: I also got the same error. For me it was fixed with replacing "DE" by "de".