Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select Folders / Timeline Path [Nextcloud <25] #111

Closed
zell-mbc opened this issue Oct 25, 2022 · 12 comments
Closed

Can't select Folders / Timeline Path [Nextcloud <25] #111

zell-mbc opened this issue Oct 25, 2022 · 12 comments
Labels
bug Something isn't working fixed-upstream Fixed in an upstream package

Comments

@zell-mbc
Copy link

zell-mbc commented Oct 25, 2022

This post is in reference to the exchange here: https://www.reddit.com/r/NextCloud/comments/ybshbu/comment/itq9r0d/?context=3

image

I did update to v3.3.7 and the new dialog opens. Unfortunately the wheel (2) keeps on spinning.
This may be because the path in (1) is wrong, doesn't exist, a leftover from my tests yesterday. But I can't clear that string because the dialog opens right away whenever I select the field.
Same happens when selecting "Timeline Path"

I tried to remove and reinstall the app, but the paths were kept.

Edit: Just saw your question re. JavaScript on Reddit.
Here's what I can see:
image

Edit, Edit: Think I should mention that I am running NC on Docker, not sure if it's relevant though.

@pulsejet
Copy link
Owner

pulsejet commented Oct 25, 2022

Thanks for filing the issue. Can you check the JS console for any errors?

@pulsejet pulsejet added bug Something isn't working needs details Issue waiting for more details labels Oct 25, 2022
@pulsejet
Copy link
Owner

Okay, let me see if I can repro this. To be sure, this is Firefox, right? Latest version?

@zell-mbc
Copy link
Author

zell-mbc commented Oct 25, 2022

LibreWolf, a stripped down version of Firefox. I can test Chromium as well

Edit: Same issue with Chromium

@zell-mbc
Copy link
Author

image

@pulsejet
Copy link
Owner

Can you try running

occ user:setting username memories timelinePath "/"
occ user:setting username memories foldersPath "/"

to see if that fixes it? Replace username with yours.

@zell-mbc
Copy link
Author

The docker equivalent ( docker exec --user www-data nextcloud-app php occ user:setting thomas memories foldersPath "/") for both paths, did go through without an error.
And Bingo!
The dialog now works, shows my NC filestructure

Next step is to run the occ index command I guess?

I guess I could set the path for my users the same way I just deleted the wrong path?

@pulsejet
Copy link
Owner

Yep, you can set it the same way or let them do it themselves. There's an initial start page now (see #109)

@zell-mbc
Copy link
Author

Cool! Index is running. Thanks a lot for being so responsive!

@pulsejet
Copy link
Owner

For future reference, this issue is already fixed in Nextcloud 25. Please keep this issue open so others can find it; I'll close when Nextcloud 26 comes out.

@pulsejet pulsejet reopened this Oct 25, 2022
@pulsejet pulsejet removed the needs details Issue waiting for more details label Oct 25, 2022
@pulsejet pulsejet changed the title Can't select Folders Path Can't select Folders Path [Nextcloud <25] Oct 25, 2022
@pulsejet pulsejet changed the title Can't select Folders Path [Nextcloud <25] Can't select Folders / Timeline Path [Nextcloud <25] Oct 25, 2022
@zell-mbc
Copy link
Author

zell-mbc commented Oct 25, 2022

Selecting the folder a second time seems to add an additional "".
Two "/" in a path is usually not a problem but thought I'd flag it.

image

By the way, I think I understand what Timeline Path is about, that's my photos, but whats the meaning of "Folders Path" then?
Edit: Think I got it, this setting is used for the Folder tab, I guess for cases where people want to access photos outside of their timeline.

@pulsejet
Copy link
Owner

pulsejet commented Oct 25, 2022

Selecting the folder a second time seems to add an additional "". Two "/" in a path is usually not a problem but thought I'd flag it.

Shouldn't be a problem. Thanks for reporting anyway!

By the way, I think I understand what Timeline Path is about, that's my photos, but whats the meaning of "Folders Path" then? Edit: Think I got it, this setting is used for the Folder tab, I guess for cases where people want to access photos outside of their timeline.

Yep. Earlier behavior was to default this to /. See #85

@pulsejet pulsejet added the fixed-upstream Fixed in an upstream package label Oct 31, 2022
@ku8az
Copy link

ku8az commented Dec 25, 2022

I have similar problem, after new installation of Memories I can't select Timeline folder, nothing happens and dialog reappears. In JS console is an error: An exception occurred while executing a query: SQLSTATE[21000]: Cardinality violation: 7 ERROR: more than one row returned by a subquery used as an expression
After setting of both folders manually via occ, I get the same error in UI as well.

Raspberry Pi 4 (4GB)
NextCloud 25.0.2
PostgreSQL 13.8
Memories 4.9.3

Stacktrace:
OC\DB\Exceptions\DbalException: An exception occurred while executing a query: SQLSTATE[21000]: Cardinality violation: 7 ERROR: more than one row returned by a subquery used as an expression

/var/www/.../lib/private/DB/ConnectionAdapter.php - line 69:
OC\DB\Exceptions\DbalException::wrap()
/var/www/.../apps/memories/lib/Db/TimelineQueryDays.php - line 328:
OC\DB\ConnectionAdapter->executeQuery()
/var/www/.../apps/memories/lib/Db/TimelineQueryPeopleRecognize.php - line 75:
OCA\Memories\Db\TimelineQuery->executeQueryWithCTEs()
/var/www/.../apps/memories/lib/Controller/PeopleController.php - line 59:
OCA\Memories\Db\TimelineQuery->getPeopleRecognize()
/var/www/.../lib/private/AppFramework/Http/Dispatcher.php - line 225:
OCA\Memories\Controller\PeopleController->recognizePeople()
/var/www/.../lib/private/AppFramework/Http/Dispatcher.php - line 133:
OC\AppFramework\Http\Dispatcher->executeController()

Edit:
After DB schema regeneration and running all migrates, the folder selection dialog reacted as expected. However, UI error remains and I'm not able to use the application at all. After selection of almost anything in left menu the error is thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed-upstream Fixed in an upstream package
Projects
None yet
Development

No branches or pull requests

3 participants