Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to sidebar #173

Closed
illnesse opened this issue Nov 7, 2022 · 8 comments
Closed

Add path to sidebar #173

illnesse opened this issue Nov 7, 2022 · 8 comments
Labels
feature New feature or request
Milestone

Comments

@illnesse
Copy link

illnesse commented Nov 7, 2022

Haven't had the time to debug this one yet, but i'm getting it often and i can reproduce it reliably

  • Select a photo
  • open "view in folder" in a new tab
  • both tabs freeze for a couple seconds (maybe due to reflow? idk)

image
image
image

this is probably not much help yet, i'll keep you posted

@pulsejet
Copy link
Owner

pulsejet commented Nov 7, 2022

The view in folder button does basically nothing beside opening a new tab, so not sure where to begin 😄

Do you also see this if opening it from the new viewer?

@pulsejet pulsejet added the performance Issues related to performance label Nov 7, 2022
@illnesse
Copy link
Author

illnesse commented Nov 10, 2022

I think the issue is a files app problem as View in folder opens the preview of an image in the foreground, but with a folder consisting of several thousand photos in the background (like fo example "Photos from 2021" from Google Takeout in my case) Probably not much you can do about that, it's just Nextcloud being Nextcloud. They really should be using lazy load for longer lists like dir listings

Actually i only use this feature to find out the exact path of a file, because currently there is no other way to see the full path of selected photos, maybe you could add that to the sidebar somehow, then we won't have to use the slow nextcloud default apps as much :D

@pulsejet
Copy link
Owner

Ah yes, that makes sense. The files app does do lazy loading, but it needs to load the entire thing to scroll to a particular file. Not much we can do there, but adding the full path to the sidebar makes sense.

@illnesse illnesse changed the title Strange performance issue when opening "View in folder" in a new tab Add path to sidebar Nov 11, 2022
@pulsejet pulsejet added feature New feature or request and removed performance Issues related to performance labels Nov 12, 2022
@pulsejet
Copy link
Owner

I'm kinda stuck about the design for this. #68 shows how the sidebar looks. There seems no easy way to put a unix path in here without looking ugly ...

@pulsejet pulsejet added the help wanted Extra attention is needed label Nov 12, 2022
@illnesse
Copy link
Author

illnesse commented Nov 12, 2022

image

image

maybe something like this? i just put it in the EXIF tab to see how it would look, no idea if you even have access to that.. i'll look at the vue code and might do a PR when i get around to it, it still needs some icon paddding and white-space / word-wrap / max-width magic, or maybe wrap it in <pre> so it just wraps around at the end of the line ignoring whitespace

@pulsejet
Copy link
Owner

That looks nice! Should be straightforward to implement, we already have the path somewhere in Vue. I'll let you take this one: really need more people to get into the code ;)

Making it a bit smaller / monospace might also be interesting.

@meichthys
Copy link
Contributor

Just chiming in here to agree that adding it to the exif (now called info) tab seems like the logical place for this to show up (especially that it's now called "info")

@pulsejet pulsejet added this to the 5.5 milestone Aug 23, 2023
@pulsejet pulsejet removed the help wanted Extra attention is needed label Aug 25, 2023
@pulsejet
Copy link
Owner

This is now available as an option
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants