Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After Update to 4.7.2, NC logs spaming by Error: OCA\Memories\Controller\DaysController #207

Closed
EVOTk opened this issue Nov 15, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@EVOTk
Copy link

EVOTk commented Nov 15, 2022

Hello,
After Update to 4.7.2, NC logs spaming by Error: OCA\Memories\Controller\DaysController

I sometimes had thumbnails that didn't load the first time but otherwise, I didn't see anything special, Memories seems to work normally.

image

Error: OCA\Memories\Controller\DaysController::OCA\Memories\Controller\{closure}(): Argument #1 ($node) must be passed by reference, value given at /config/www/nextcloud/apps/memories/lib/Controller/FoldersTrait.php#45
    <<closure>>
    OC\Log\ErrorHandler::onError()
    /config/www/nextcloud/apps/memories/lib/Controller/FoldersTrait.php - line 45:
    array_map()
    /config/www/nextcloud/apps/memories/lib/Controller/DaysController.php - line 78:
    OCA\Memories\Controller\DaysController->getSubfoldersEntry()
    /config/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 225:
    OCA\Memories\Controller\DaysController->days()
    /config/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 133:
    OC\AppFramework\Http\Dispatcher->executeController()
    /config/www/nextcloud/lib/private/AppFramework/App.php - line 172:
    OC\AppFramework\Http\Dispatcher->dispatch()
    /config/www/nextcloud/lib/private/Route/Router.php - line 298:
    OC\AppFramework\App::main()
    /config/www/nextcloud/lib/base.php - line 1047:
    OC\Route\Router->match()
    /config/www/nextcloud/index.php - line 36:
    OC::handleRequest()
@EVOTk
Copy link
Author

EVOTk commented Nov 15, 2022

Mmmmm, I remember being in the Settings after the update.

Also I remember that in "Folder Path", there was nothing but "/"
image

I can't seem to put it back, do you think this is the cause?

@EVOTk
Copy link
Author

EVOTk commented Nov 15, 2022

Hello,
I'm resolve manually :

Before :
image
After :
image

and it works as before, and I have no more errors in the NC logs! So there was this "/" before. I had to "break" it when I opened the settings.

However, I'm not sure I understand the difference between "Folder Path" and "Timeline Path".

Can you give me a use case? Because I think I'm not using it correctly.

@pulsejet pulsejet added the bug Something isn't working label Nov 16, 2022
@pulsejet
Copy link
Owner

However, I'm not sure I understand the difference between "Folder Path" and "Timeline Path".

Can you give me a use case? Because I think I'm not using it correctly.

#85. The folder path is the root for your "Folders" tab. Timeline path is the root for the "Timeline" and everything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants