Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a "nolint" capability #240

Open
justinvp opened this issue Apr 23, 2020 · 1 comment
Open

Provide a "nolint" capability #240

justinvp opened this issue Apr 23, 2020 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@justinvp
Copy link
Member

justinvp commented Apr 23, 2020 •
edited
Loading

Question from a customer:

Can you “acknowledge” a CrossGuard-policy, enforcementLevel: "advisory", directly at the resource? To get this check out of the list of policy violations. Similar like nolint flags.
@justinvp justinvp added the kind/enhancement Improvements or new features label Jul 18, 2023
@justinvp justinvp mentioned this issue Jul 17, 2024
Closed
@psirenny
Copy link

psirenny commented Aug 1, 2024

Looking forward to seeing this feature in the future 😄. We avoid advisory policies because they train developers to ignore warnings. It would be better to pair nolint with mandatory policies so that policies were either followed or intentionally disabled. Whether to disable a policy could then be discussed in the pull request review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@psirenny @justinvp