Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean tests directory #325

Open
awegsche opened this issue Sep 17, 2021 · 1 comment
Open

Clean tests directory #325

awegsche opened this issue Sep 17, 2021 · 1 comment
Labels
Minor Issue minor fix to be integrated eventually

Comments

@awegsche
Copy link
Contributor

Issue

The current layout of the tests directory is overly complicated and has confusing folder names (e.g. outputs inside of an inputs root folder).
The complexity of this structure is expected to increase over time.

Suggested solution:

  1. move test and verification data next to the tests, where applicable (see 2.)
    Pros:

    • easier to write new tests
    • easier to understand how a test works and where its inputs come from

    Cons:

    • mixes code with assets
  2. for global inputs (models, .linx/y files that are used by different test modules), a global testassets folder makes sense. naming has to be chosen carefully.

@awegsche awegsche added the Minor Issue minor fix to be integrated eventually label Sep 17, 2021
@mihofer
Copy link
Contributor

mihofer commented Sep 20, 2021

Create global test constant for input dir, to replace in CRDT and other tests the Path(./).parent.parent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue minor fix to be integrated eventually
Projects
None yet
Development

No branches or pull requests

2 participants