Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add peak2peak of defocussing BPMs to lin-files #373

Open
JoschD opened this issue May 8, 2022 · 0 comments
Open

[Feature Request]: Add peak2peak of defocussing BPMs to lin-files #373

JoschD opened this issue May 8, 2022 · 0 comments
Labels
Enhancement New feature or request

Comments

@JoschD
Copy link
Member

JoschD commented May 8, 2022

Feature Description

Add the average peak-to-peak for the BPMs at the defocussing quads to the header of the lin-files.
This allows for an independent check from the values in multiturn.

Possible Implementation

The pk2pk is already calculated per BPM in the lin-files. So one would only need to use

LIST_1 = ["BPM.20L3.B", "BPM.18L3.B",
          "BPM.21R3.B", "BPM.19R3.B",
          "BPM.20L7.B", "BPM.18L7.B",
          "BPM.21R7.B", "BPM.19R7.B",
          "BPM.20R2.B", "BPM.18R2.B",
          "BPM.21L4.B", "BPM.19L4.B",
          "BPM.20R6.B", "BPM.18R6.B",
          "BPM.21L8.B", "BPM.19L8.B",]

LIST_2 = ["BPM.21L3.B", "BPM.19L3.B",
          "BPM.20R3.B", "BPM.18R3.B",
          "BPM.21L7.B", "BPM.19L7.B",
          "BPM.20R7.B", "BPM.18R7.B",
          "BPM.21R2.B", "BPM.19R2.B",
          "BPM.20L4.B", "BPM.18L4.B",
          "BPM.21R6.B", "BPM.19R6.B",
          "BPM.20L8.B", "BPM.18L8.B",]

DEFOCUSSING_MONITORS = {
    1: {"X": LIST_1, "Y": LIST_2},
    2: {"X": LIST_2, "Y": LIST_1}
}

(copied from the old multiturn gui: https://gitlab.cern.ch/acc-co/lhc/lhc-multiturn/-/blob/master/src/java/cern/lhc/multiturn/datamanagement/MonitorSetImpl.java#L42 )

and use the ones that are present and good (not sure when the bad-bpms are filtered, maybe need to check which ones are in the list of bad-bpms and which ones are not.)

@JoschD JoschD added the Enhancement New feature or request label May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant