-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Broken character encoding when using the yt-music scraper #714
Comments
Great :( p.s. I will be afk tomorrow, Jan 9th, and probably the day after. Please excuse any or no replies during that time. |
This only applies to the core issue, also, I don't get that jq error, but I do get a jq error
this might have to do with the utf-8 nonsense. I'm not sure about the one you get.
Ok |
Quick question while I am afk. Can this be related to... whatever the |
Actually it might, I tried running it again, and the data from youtube looks normal, until it gets piped into the script, I thought it was broken from the start, i'll have another look. Edit: I think i fixed it. apparently setting binmode(STDOUT, "utf8") makes it not utf8????? clearly im missing something lol. The fix is in this commit: 6fe8d0d, |
I removed the line from the file, just like you have it on the patch and it now works as it should as you can see here. Nothing plays after that though (on a few results that I tried) and I have no idea why, but I will investigate it. The jq parse error when searching is still present, only the line number at the end has changed
|
Thank you for adding this to the stable version of the script, even though it will be its very last release. |
Can you please tag 2.6.2 as the latest release so that everyone can see it on the side of the main page? Thank you :) |
tbh it probably will, but you never know
you could probably just download the main ytfzf file and run it directly to test it. |
Debian packages ytfzf, but months after a new releases is made. I think 2.6.2 will be packaged in April :D |
April ends today and debian's ytfzf is still on 2.4.1! :D |
Describe the bug
When using yt-music as the scraper, the non-english characters are broken.
To Reproduce
Launch
ytfzf -c yt-music
and search for something that would return results in greek, e.g. "vevilos", as seen below.Expected behavior
The returned results inside fzf should have greek or any other character, like they do when youtube is used as a scrapper (
ytfzf -c yt
).Screenshots
Information
readlink $(which sh)
: dashAdditional context
The font on urxvt (black text on light grey background) is hack and on alacritty (light grey text on black background) is cascadia mono. Both support non-english or utf8 characters. I use hack on every app that needs a monospace font, I just changed the one on alacritty for the screenshot.
Also note that when searching for some other greek... artist, e.g. anser, the search breaks completely, possibly because of some weird result.
The text was updated successfully, but these errors were encountered: