Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: thumbnails won't load when requesting more pages #717

Closed
dpicassom opened this issue Jan 23, 2024 · 2 comments
Closed

[BUG]: thumbnails won't load when requesting more pages #717

dpicassom opened this issue Jan 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@dpicassom
Copy link

First of all, great program! I love it, very effective!

Describe the bug

When i request more pages via next_page_action_shortcut new thumbnails don't ever load (entries load all right)

To Reproduce

here's the config:

show_thumbnails=1
thumbnail_viewer="mpv"
next_page_action_shortcut="ctrl-b"
async_thumbnails=1
skip_thumb_download=0

Expected behavior

for new thumbnails (of the newly added search results via next_page_action_shortcut ) to be fetched and showed async, eventually

Screenshots

Screencast.from.2024-01-23.16-37-50.webm

Sorry for the length of the video, took me too long to request a new page.

Information

  • OS: CachyOS
  • Terminal: kitty
  • Ytfzf version: ytfzf: 2.6.1
  • Output of readlink $(which sh): bash
  • (if is a thumbnail issue) run ytfzf --thumbnail-log=log.txt and post the file:
[file] Cannot open file '/tmp/ytfzf-1000/some stuff-323795/thumbnails/ux-4Dwcv6CE.jpg': No such file or directory
Failed to open /tmp/ytfzf-1000/some stuff-323795/thumbnails/ux-4Dwcv6CE.jpg.
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
VO: [gpu] 480x360 yuv420p
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
[ffmpeg/video] mjpeg: EOI missing, emulating
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
 (+) Video --vid=1 (mjpeg 480x360 1.000fps)
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
V: 00:00:00 / 00:00:00
V: 00:00:00 / 00:00:00 (0%)
Exiting... (Quit)
V: 00:00:00 / 00:00:00 (0%)

Additional context

I assume the first fail to load image is that of the first result, as it's loaded async, it wont be there until it's finished

Would be nice if waited to load the first one before loading results

Would be extremely nice if focus stayed on the terminal when mpv for thumbnail display is first called

the family guy image loaded because it's repeated from the first page results, the other's don't

@dpicassom dpicassom added the bug Something isn't working label Jan 23, 2024
@Euro20179
Copy link
Collaborator

This should now be fixed in the development branch (71b9a6d)

Would be extremely nice if focus stayed on the terminal when mpv for thumbnail display is first called

This is not really possible to implement in a way that would always work.
I'd recommend doing some hacky window rules in your window manager instead (i know this isn't great lol)

@dpicassom
Copy link
Author

Thank you , good sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants