Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 #267

Open
p8 opened this issue Aug 1, 2023 · 9 comments
Open

Release 3.0.0 #267

p8 opened this issue Aug 1, 2023 · 9 comments

Comments

@p8
Copy link
Member

p8 commented Aug 1, 2023

@zzak Can we release 3.0.0?
There are still some milestone issues but I think main has enough changes to warrant a new release.
This would also allow us to find possible issues on https://edgeapi.rubyonrails.org/

@zzak
Copy link
Member

zzak commented Aug 2, 2023

We should make sure the latest code doesn't break Rails documentation pipeline, last time I checked there was some incompatibilities.

@p8
Copy link
Member Author

p8 commented Aug 7, 2023

@zzak Do you have any links to those incompatiblities? Are these visible when creating a PR in Rails with a new version?

@jonathanhefner
Copy link
Member

There are some more changes I would like to include in 3.0.0, so my vote would be to wait a few more weeks.

But what is stopping us from pointing https://edgeapi.rubyonrails.org/ at sdoc main?

@p8
Copy link
Member Author

p8 commented Aug 7, 2023

@jonathanhefner Good idea. I've created: rails/rails#48904

@p8
Copy link
Member Author

p8 commented Aug 10, 2023

Edge is now running main. It doesn't seem to get updated though.
Probably because of the Rails documentation pipeline.
I'm not seeing any errors I can pick up.

@zzak
Copy link
Member

zzak commented Aug 10, 2023

Found this in the rails docs server logs:

[2023-08-10 23:05:05 UTC]  rvm 2.7.6 do bundle install --without db test job cable storage ujs >/dev/null
[DEPRECATED] The `--without` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `
bundle config set --local without 'db test job cable storage ujs'`, and stop using this flag
[2023-08-10 23:05:19 UTC] EDGE="1" ALL="1" rvm 2.7.6 do bundle exec rake rdoc >/dev/null
/home/rails/.rvm/gems/ruby-2.7.6/gems/bundler-2.3.22/lib/bundler/source/git/git_proxy.rb:224:in `allowed_with_path': The git source https://github.com/rails/sdoc.git is not yet checked o
ut. Please run `bundle install` before trying to start your application (Bundler::GitError)

@jonathanhefner
Copy link
Member

I noticed that the Rails 7.1 API documentation was released using main @ 947abf9, which is missing several recent improvements. So coming back to this, how does everyone feel about a 3.0.0 release? Are there still outstanding issues?

Personally, there are a few improvements I would like to make in the future, but I feel like we are at a good spot for a release. Though I would like to get some opinions on #325, and possibly include that.

@zzak
Copy link
Member

zzak commented Oct 8, 2023

I would like to catch up with @AmandaPerino to make sure we're on the same page before cutting a major release, now that RailsWorld is over hopefully there will be more cycles to focus on this stuff.

@jonathanhefner
Copy link
Member

Sounds good. That being the case, I've updated the ref in Rails main so that https://edgeapi.rubyonrails.org/ now reflects what we have in SDoc main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants