Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from node-sass to dart-sass #2673

Closed
JoshRobertson opened this issue Jul 29, 2020 · 6 comments
Closed

Migrate from node-sass to dart-sass #2673

JoshRobertson opened this issue Jul 29, 2020 · 6 comments

Comments

@JoshRobertson
Copy link

Has there been any discussion about migrating from node-sass to dart-sass?

Dart-sass is now the primary implementation of sass, and Webpack itself recommends dart-sass:
https://webpack.js.org/loaders/sass-loader/

@oshanz
Copy link

oshanz commented Aug 10, 2020

This is really important.

  1. python2 is now on EOL. node-sass doesn't support python 3. Python 3 support by bumping node-gyp to 6.1.0 sass/node-sass#2936
  2. node-sass has plan to make it deprecate. Mark Node Sass as deprecated sass/node-sass#2952

@justin808
Copy link
Contributor

Is there any way to monkey patch the child dependency?

@tegandbiscuits
Copy link

Just wanted to say that #2716 should resolve this.

I'm not sure when it'll actually go out to NPM, but I was able to just replace @rails/webpacker with the github repo.

@dreyks
Copy link
Contributor

dreyks commented Nov 5, 2020

now that libsass (and hence node-sass) is deprecated maybe we should cut another 5.x release with this change?

@Pezmc
Copy link

Pezmc commented Mar 15, 2021

How do we go about cutting a new 5.x release, there are a few things now waiting to go out!

@pedrofurtado
Copy link
Member

pedrofurtado commented Mar 15, 2021

We can follow the progress on this PR 🤝 : #2914

@dhh dhh closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants