Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate creates empty go mod bump prs #271

Open
thardeck opened this issue Apr 25, 2024 · 1 comment
Open

Renovate creates empty go mod bump prs #271

thardeck opened this issue Apr 25, 2024 · 1 comment

Comments

@thardeck
Copy link

Renovate creates empty go mod bump prs. It basically is a bump but when we run go mod tidy, the changes are removed, so they are effectively empty.

We have a CI which checks for automatic generated changes, which among others run go mod tidy, that's why our CI was failing.

These are the two prs I saw with this issue:
rancher/fleet#2303
rancher/fleet#2306

Maybe renovate bumps an indirect dependency but the other components still require the old version, that's why the new component is not used and removed by go mod tidy again.

@thardeck
Copy link
Author

thardeck commented Jun 12, 2024

@pjbgf another example of empty mod bumps: rancher/fleet#2501

If I run go mod tidy on it the changes are reversed, that's why our own CI verifcation (Verify generated code changes / check-changes) is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant