Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measuring Cython code coverage #93

Open
jakirkham opened this issue Aug 15, 2024 · 3 comments
Open

Measuring Cython code coverage #93

jakirkham opened this issue Aug 15, 2024 · 3 comments

Comments

@jakirkham
Copy link
Member

Most RAPIDS projects measure coverage in Python. Though it appears not all measure code coverage in Cython. However there is lots of Cython code in RAPIDS. So it would be ideal to capture this in our code coverage statistics (as well as uncover parts of Cython code that is not currently covered in tests)

Here is an example from cuML where Cython code coverage was added: rapidsai/cuml#3111

@vyasr
Copy link
Contributor

vyasr commented Aug 15, 2024

Do we know whether cuml's code coverage of Cython actually works? Last I checked (admittedly quite a long time ago) the Cython coverage plugin did not work with scikit-build. I would a priori expect similar issues with scikit-build-core.

@jakirkham
Copy link
Member Author

If it doesn't work with scikit-build-core, can we please raise an issue?

@vyasr
Copy link
Contributor

vyasr commented Aug 16, 2024

I'm asking because I don't know if it does, but if someone tests it and finds that it doesn't then yes certainly we should raise an issue. I just commented on the corresponding Cython/coverage/Meson issue since it looks like someone almost has that working. If someone has bandwidth to test this, that PR branch would probably be a good place to start if coverage doesn't work with the latest Cython out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants