Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CAGRA IP Distance returning invalid neighbors #152

Open
cjnolet opened this issue May 24, 2024 · 1 comment
Open

[BUG] CAGRA IP Distance returning invalid neighbors #152

cjnolet opened this issue May 24, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cjnolet
Copy link
Member

cjnolet commented May 24, 2024

Zilliz changed their CAGRA testing for IP distance to generate random numbers with negatives and they found some of the neighbors being returned are -1.

What's also weird about their test results is that they were using nn-descent and not getting an exception (since nn-descent doesn't yet support IP).

While beginning triage this issue in Python, I realized that the IP distance was never exposed in the Python layer. We should fix this and also add explicit pytests to verify 1) correct neighbors are returned when negatives are in the input vectors, and 2) the algorithm fails gracefully when IP distance is used with nn-descent as the build algo.

@cjnolet cjnolet added the bug Something isn't working label May 24, 2024
@cjnolet
Copy link
Member Author

cjnolet commented May 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

2 participants