Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing private keys #11

Closed
Bill-Kunj opened this issue Nov 11, 2022 · 10 comments
Closed

Testing private keys #11

Bill-Kunj opened this issue Nov 11, 2022 · 10 comments
Assignees
Labels
documentation Improvements or additions to documentation Testing

Comments

@Bill-Kunj
Copy link
Contributor

Testing will require the use of standard private keys, which need to be created and managed

@Valentine-Mario
Copy link
Collaborator

@Bill do we have the a list of testing keys and addresses or should I compute one into a csv file?

@Bill-Kunj
Copy link
Contributor Author

Bill-Kunj commented Nov 14, 2022

@Bill do we have the a list of testing keys and addresses or should I compute one into a csv file?

We can use the RGOV test keys (https://github.com/rchain-community/rgov/tree/master/bootstrap/PrivateKeys) to enable inter-operation and eventual testing between the repositories/teams.
We probably need at least one additional private key for testing that isn't in RGOV, however.

@Bill-Kunj
Copy link
Contributor Author

@David405 Do we have private keys for testing?

@Bill-Kunj Bill-Kunj pinned this issue Nov 26, 2022
@Bill-Kunj Bill-Kunj added the documentation Improvements or additions to documentation label Nov 26, 2022
@David405
Copy link
Collaborator

Testing Keys 1
Private key | 540eabea549412552b7b125a4317b5b006fc6429d2262156f53ce81e66b4424c

Testing Keys 2
Private key | 5ac6a1a363d352e3f8c4c31533ebf72aa664d8865305514ee5f6984b5b3ac0c8

Testing Keys 3
Private key | 8981468ca0ca8d3a7657bafb8ce26aa16b0d5cd0d45b5db03af7920804061718

@Valentine-Mario
Copy link
Collaborator

Testing Keys 1 Private key | 540eabea549412552b7b125a4317b5b006fc6429d2262156f53ce81e66b4424c

Testing Keys 2 Private key | 5ac6a1a363d352e3f8c4c31533ebf72aa664d8865305514ee5f6984b5b3ac0c8

Testing Keys 3 Private key | 8981468ca0ca8d3a7657bafb8ce26aa16b0d5cd0d45b5db03af7920804061718

I think this should be in a file with the equivalent rev address, ETH address and pub key. That way we know what to assert for in the test

@David405
Copy link
Collaborator

David405 commented Nov 29, 2022

We can always generate those from the private keys, but I can create a file for those.

@Bill-Kunj
Copy link
Contributor Author

We can always generate those from the private keys, but I can create a file for those.

How about one file per key that contains ETH, REV, PubK, etc?

@David405
Copy link
Collaborator

why would need a separate file for each? do we want to run nodes using this library?

@Bill-Kunj
Copy link
Contributor Author

Bill-Kunj commented Nov 29, 2022

why would need a separate file for each? do we want to run nodes using this library?

Maybe I didn't type it right. One file for each private key that contains the PK, ETH, REV, PubK.
No validators use these keys. Just REV balances in our genesis wallets.txt for testing.
I was also thinking of a configuration option like --pkfile or something equivalent that could grab the private key when running tests.

@Valentine-Mario
Copy link
Collaborator

We can always generate those from the private keys, but I can create a file for those.

The goal of having all of them is so that we can know independent of the code what to expect, and the code should generate the expected values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Testing
Projects
None yet
Development

No branches or pull requests

3 participants