Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact client implementation authors about splitting off into new libraries #121

Open
4 of 6 tasks
mihasya opened this issue Jul 4, 2015 · 15 comments
Open
4 of 6 tasks
Assignees

Comments

@mihasya
Copy link
Collaborator

mihasya commented Jul 4, 2015

Other libraries to document:

@mihasya mihasya self-assigned this Jul 4, 2015
@cyberdelia
Copy link
Contributor

From the gist of it, it sounds like a good idea, maybe you could share some details you have in mind?

@mihasya
Copy link
Collaborator Author

mihasya commented Jul 4, 2015

Howdy! Basically, just spinning the individual reporters that require an external dependency (like a service) into their own little repos that import go-metrics and are referenced in go-metrics README and docs, but are otherwise independent. So many of the issues and PRs are for things like Stathat InfluxDB, which none of the maintainers of go-metrics use, so they just languish. I think it's a more maintainable path forward.

@cyberdelia
Copy link
Contributor

@mihasya Any preferences on the naming of theses "spin-off" ?

@mihasya
Copy link
Collaborator Author

mihasya commented Jul 4, 2015

@cyberdelia hmm.. not entirely sure, but I also don't think it's worth agonizing over. They'll theoretically only be imported once, in main.go, correct?

@mihasya
Copy link
Collaborator Author

mihasya commented Jul 4, 2015

@cyberdelia probably something like metrics-graphite or similar will work just fine.

@mihasya
Copy link
Collaborator Author

mihasya commented Jul 5, 2015

@cyberdelia you can see my stab at the Librato client's move here #122

@cyberdelia
Copy link
Contributor

@mihasya
Copy link
Collaborator Author

mihasya commented Jul 5, 2015

@cyberdelia nice and easy. Thanks!

@bketelsen
Copy link
Contributor

I don't use the stathat lib at all, if someone else wants to take ownership - I'm happy to relinquish any "control"

@mihasya
Copy link
Collaborator Author

mihasya commented Jul 6, 2015

@bketelsen thanks for letting us know. We'll find it a home, even if it's just under my account with a "MAINTAINER WANTED" in the README.

@mihasya
Copy link
Collaborator Author

mihasya commented Jul 6, 2015

It looks like the github account for Michael Crosby is @crosbymichael. Michael, would you be interested in becoming the maintainer for a split-out version of the influx reporter?

@crosbymichael
Copy link
Contributor

@mihasya ya, i can take the influx part

@mihasya
Copy link
Collaborator Author

mihasya commented Jul 6, 2015

@crosbymichael Beauty! Please check out the repos myself and @cyberdelia have created for librato and graphite

@slayer
Copy link

slayer commented Aug 2, 2015

http://prometheus.io/ looks like a candidate for the creation of a client

@talbright
Copy link

Is there something inherently incompatible with statsd and this library, that there isn't an exporter for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants