Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Highlight issue - Wrong page switch + Note icon missing #451

Open
mrifni opened this issue Aug 9, 2021 · 2 comments
Open

Highlight issue - Wrong page switch + Note icon missing #451

mrifni opened this issue Aug 9, 2021 · 2 comments
Labels

Comments

@mrifni
Copy link

mrifni commented Aug 9, 2021

What happened?

I was testing the latest develop branch for the new highlights based on the decorator pattern. And found these two issues below.

  1. After adding a note it takes to next page.
  2. Notes icon on the left hand doesnt appear until I reopen the book.
pr.1.mp4

Expected behavior

Note icon should appear as soon as a note is added and it should stay on the same page.

How to reproduce?

Please check the video.

Environment

All latest develop branch.

Development environment

  • OS: macOS
  • IDE: Android Studio arctic fox

Testing device

  • Android version: Android 8
  • Model: Pixel 4a
  • Is it an emulator? Yes
@mickael-menu
Copy link
Member

I can't reproduce any of the bugs on a (real) Pixel 3a. Did you reproduce on a device too? You didn't indicate the Android version as well.

From your video, it looks like the viewport is shifting when the virtual keyboard opens.

@mrifni
Copy link
Author

mrifni commented Aug 9, 2021

I can't reproduce any of the bugs on a (real) Pixel 3a. Did you reproduce on a device too? You didn't indicate the Android version as well.

From your video, it looks like the viewport is shifting when the virtual keyboard opens.

Android version is updated in the description now.( Android 8) I couldn't reproduce this in the real device either. It could be because higher android version ? or device is faster compare to emulator ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants