Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change margins in Continuous mode #405

Open
gbitzes opened this issue Sep 20, 2015 · 3 comments
Open

Cannot change margins in Continuous mode #405

gbitzes opened this issue Sep 20, 2015 · 3 comments

Comments

@gbitzes
Copy link

gbitzes commented Sep 20, 2015

When Continuous mode is seleted, I am not able to change the margins, and the text always occupies the entire width of the screen.

I'm really used to scrolling when reading text on a screen, I'm not comfortable having pages.. I'd rather use Continuous mode, but it's a bit tiring to have my eyes travel a rather large horizontal distance for each line. Changing the margin option seems to have no effect when in this mode. (I'm using the latest commit of branch develop)

Any plans to fix it? Thanks!

@danielweck
Copy link
Member

Thank you for your feedback.
We definitely need to fix support for "margins" in the Chrome app / cloud reader (things are a little different in native launcher apps, which do not use the same "margin" heuristic as found the readium-js-viewer preference dialog's slider).

  1. in paginated reflowable documents, the width of a run of text (column width) is limited by a maximum value (just as you say: to offer comfortable horizontal eye scanning across the screen), and there is also a minimum threshold to ensure that a single column in two-page synthetic spread mode does not shrink so narrow as to become unreadable (in which case there is an automatic switch to single page).

  2. in scroll mode, the document occupy the full viewport width, with no application of either margins (whitespace padding) or maximum width limit, resulting in potentially long lines of text.

To fix this, I think that we need to allow users to configure the min/max thresholds (or at least the max one, in order to minimize UI / configuration complexity), and we need to apply that same logic to the scroll view. Fixed layout documents are treated differently, as they obey layout rules that are more publisher-specific.

Note that right now, the "margins" slider in the preferences dialog does not behave in the same way that it used to (before the harmonization of the pagination layout in native launcher apps), resulting in confusing lack of visible whitespace change around the text. This is a known bug, see:
#179 (comment)

@danielweck
Copy link
Member

image

This is an example from Gutenberg which shows how the lack of margins affects readability. Resizing the browser window is not always a possibility.

@danielweck
Copy link
Member

Related: #498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants