Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current "themes" system only supports global background and foreground color #594

Open
danielweck opened this issue Dec 15, 2016 · 1 comment
Open

Current "themes" system only supports global background and foreground color #594

danielweck opened this issue Dec 15, 2016 · 1 comment
Labels
difficulty:Dev func:CSS func:UX priority:Medium status:NeedMoreInfo type:Enhancement

Comments

@danielweck
Copy link
Member

See:
#203 (comment)

So, right now hyperlinks are color-inverted because of an internal / architectural limitation:
https://github.com/readium/readium-js-viewer/blob/develop/src/js/ReaderSettingsDialog.js#L14
(previewStyle.backgroundColor and previewStyle.color)

There would be noticeable improvements in readability if color themes described when major elements (such as hyperlinks) should be styled differently than the rest of the HTML document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:Dev func:CSS func:UX priority:Medium status:NeedMoreInfo type:Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck