Skip to content
This repository has been archived by the owner on Nov 20, 2020. It is now read-only.

Apollo Client 3 branch? #121

Open
jeddeloh opened this issue May 7, 2020 · 5 comments
Open

Apollo Client 3 branch? #121

jeddeloh opened this issue May 7, 2020 · 5 comments

Comments

@jeddeloh
Copy link
Member

jeddeloh commented May 7, 2020

I wonder if #117 presents an opportunity to cut an apollo-client-3 branch and do some restructuring to better match types (and possibly modules) in @apollo/client? I’d be happy to help with this.

@jfrolich
Copy link
Member

jfrolich commented May 7, 2020

Yes that would be great!

@fakenickels
Copy link
Member

that would be wonderful! @jeddeloh

@jeddeloh
Copy link
Member Author

jeddeloh commented May 8, 2020

Great. Unless someone wants it first, I'll plan on starting with useQuery and following it to the end, sticking as close as possible to @apollo/client and get a PR up for discussion. Hopefully that will be sufficient to see if this is a path we actually want to go down :)

@jfrolich
Copy link
Member

jfrolich commented May 8, 2020

That would be amazing @jeddeloh. FYI: I am actually exploring an API where we could extend the Query/Mutation/Subscription with a use function, so we don't need definition anymore. I will experiment a bit more to see if we make this the default for graphql-ppx 1.0. But don't worry it is fairly easy to adapt to this when we have the old API.

@jeddeloh
Copy link
Member Author

@fakenickels @jfrolich #122 is up for discussion.

@jfrolich, I see now I should have been paying attention to the graphql channel on discord! Seriously, this graphql-ppx 1.0 is like the gift you desperately wished for but didn't expect, and now that you've received it, it's even better than you could have imagined. 🎅 I'll take a look at your proposal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants