Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve smart select #307

Open
inwardmovement opened this issue Jun 16, 2020 · 2 comments
Open

Improve smart select #307

inwardmovement opened this issue Jun 16, 2020 · 2 comments

Comments

@inwardmovement
Copy link

inwardmovement commented Jun 16, 2020

vsc2

Steps to Reproduce:

  • editor.action.smartSelect.expand within parenthesis, backticks, single/double quotes containing a space, an hyphen, etc. (It seems ok with brackets or curly brackets).

Expected:

  • A step selecting everything inside quotes.
  • A step selecting everything outside quotes.

Result:

  • Jumping outside quotes.

microsoft/vscode#100081

Version: 1.46.0 (user setup)
Commit: a5d1cc28bb5da32ec67e86cc50f84c67cc690321
Date: 2020-06-10T09:03:20.462Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
@inwardmovement inwardmovement changed the title Improve YAML smart select Improve smart select Jun 16, 2020
@fbricon
Copy link
Contributor

fbricon commented Jun 16, 2020

@aeschli where is the smart selection API documented? Doesn't seem to be a part of the LSP. Its announcement is lacking some important info

@aeschli
Copy link
Contributor

aeschli commented Jun 16, 2020

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_selectionRange

Given is a set of position and for each position provide a hierarchy of selection ranges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants