very slow completion with aws cloudformation schema

[v-au]

Describe the bug

When Yaml Completion is enabled it takes 20+ seconds for the Intellisense list to pop up.

Expected Behavior

Intellisense should popup instantly.

Current Behavior

20+ seconds until the completion list shows up.

Steps to Reproduce

Enable/disable YAML Completion. See attached screen capture.

Environment

• [x ] Windows
• Mac
• Linux
• other (please specify)

2021-10-28_03-38-13.mp4

[remcohaszing]

I’m experiencing the same issue for app-definition.yaml. Using VSCode YAML 0.23.0 completion works almost instantly. Using 1.1.0 it takes multiple seconds.

The issue also appears for .prettierrc.yaml, but it’s not as extreme. This makes me think it might be related to the schema complexity.

[evidolob]

@remcohaszing @v-au Could you share yaml samples on which you have problems?
As I cannot reproduce this on my laptop.

[remcohaszing]

A practical example can be found here. There’s no need to install yarn dependencies or even to clone the repo. Just downloading the file as app-definition.yaml should be sufficient to reproduce the issue.

The problem is much worse in another much larger app-definition.yaml file I’m currently working with, but unfortunately it’s proprietary. This makes me think the issue may be related not (only) to schema complexity, but also to complexity of the YAML contents.

Using VSCode YAML 0.23.0 completion is pretty much instantaneous.

Using VSCode YAML 1.0.0 or 1.1.0 completion is slow, as described in this issue.

Using VSCode YAML 1.1.1 shows an error that the JSON schema reference can’t be resolved. This is a new issue.

[evidolob]

@remcohaszing thx, now I can profile work with https://gitlab.com/appsemble/amersfoort/-/blob/main/apps/werkplek-reservering/app-definition.yaml to find the problem

[evidolob]

I found the problem and seems to fix it:

Screen.Recording.2021-11-09.at.10.58.30.mov

Completion list shows in 10-20 times faster 🥳
Preparing PR today.