Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema comment still not working properly in 1.1.0. #629

Closed
2 of 4 tasks
jedieaston opened this issue Nov 1, 2021 · 0 comments · Fixed by redhat-developer/yaml-language-server#589
Closed
2 of 4 tasks
Milestone

Comments

@jedieaston
Copy link

jedieaston commented Nov 1, 2021

Describe the bug

If you have a schema comment, VSCode-YAML will try to use the schema mentioned and the schema(s) it finds in schema store, creating nonsensical problems.

image

Expected Behavior

The schema in the comment should override the schema the YAML extension/language server gets from the schema store.

Current Behavior

Both schemas are being used simultaneously, with the one from the schema store being prioritized.

Steps to Reproduce

  1. Load a file that vscode-yaml thinks has a match in the schema store, even if it really doesn't match.
  2. Make sure that file has a schema comment somewhere in the file. (#yaml-language-server $schema=...)
  3. Note that the schema that vscode-yaml finds isn't being overridden by the schema comment, like it was pre 1.0.

Environment

  • Windows
  • Mac
  • Linux
  • other (please specify)

Sample file attached. If this is intended behavior for some reason, we'll need to remove our paths from the schema store since they aren't working. I can't imagine why it would be intentional though.

Thanks!

Obsidian.Obsidian.installer.yaml.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants