Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign features of YAML Language Server with JSON Language Server #142

Closed
7 tasks done
JPinkney opened this issue Mar 27, 2019 · 1 comment
Closed
7 tasks done
Assignees
Milestone

Comments

@JPinkney
Copy link
Contributor

JPinkney commented Mar 27, 2019

Currently, the YAML language server is quite a bit behind the JSON language server in terms of features and will take quite a bit of work to get everything back up to date. This issue will keep track of everything that needs to be done.

  • Extend the JSON parser from vscode-json-languageservice rather then use the current version in yaml-language-server
  • Replace yamlParser code that recursively builds the AST with new types
  • Replace documentSymbols with vscode-json-languageservice's implementation of document symbols and change it to work with YAML's multiple documents
  • Replace yamlHover with vscode-json-languageservice's implementation for json, should work the same since theres nothing specific to YAML in this.
  • Replace yamlValidation with vscode-json-languageservice's implementation for json, should work the same since theres nothing specific to YAML in this.
  • See if there is a way to extend the jsonSchemaService
  • See what other features we can use from vscode-json-languageservice that would be relevant

By doing this we solve:
redhat-developer/vscode-yaml#154
redhat-developer/vscode-yaml#151
#133
#105

@JPinkney JPinkney added this to the 0.5.0 milestone Mar 27, 2019
@JPinkney JPinkney self-assigned this Mar 27, 2019
@marosg42
Copy link

@JPinkney I only wanted to bump this issue. I just started to use yaml extension in vscode and realized jsonschema draft-7 enhancement if-then-else is not available here. It would be really cool to have this available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants