You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been adding yaml-language-server to Nova.app, this makes writing and managing YAML so much easier, thank you! Nova doesn't support dynamicRegistration and it is causing two Unhandled promise rejections as of 0.20.0.
It shouldn't have any unhandled promise rejections, in Node 15+ they will cause the process to exit.
Current Behavior
Error messages
Registering request handler for workspace/didChangeWorkspaceFolders failed.
(node:67143) UnhandledPromiseRejectionWarning: Error: Invalid parameter: registrations
Registrations must be of type Registration[]
at handleResponse (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:477:48)
at processMessageQueue (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:292:17)
at Immediate.<anonymous> (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:276:13)
at processImmediate (internal/timers.js:464:21)
at emitUnhandledRejectionWarning (internal/process/promises.js:168:15)
at processPromiseRejections (internal/process/promises.js:224:9)
at processTicksAndRejections (internal/process/task_queues.js:96:32)
(node:67143) Error: Invalid parameter: registrations
Registrations must be of type Registration[]
at handleResponse (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:477:48)
at processMessageQueue (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:292:17)
at Immediate.<anonymous> (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:276:13)
at processImmediate (internal/timers.js:464:21)
Registering request handler for workspace/didChangeConfiguration failed.
(node:67143) UnhandledPromiseRejectionWarning: Error: Invalid parameter: registrations
Registrations must be of type Registration[]
at handleResponse (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:477:48)
at processMessageQueue (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:292:17)
at Immediate.<anonymous> (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:276:13)
at processImmediate (internal/timers.js:464:21)
at emitUnhandledRejectionWarning (internal/process/promises.js:168:15)
at processPromiseRejections (internal/process/promises.js:224:9)
at processTicksAndRejections (internal/process/task_queues.js:96:32)
at runNextTicks (internal/process/task_queues.js:64:3)
at processImmediate (internal/timers.js:437:9)
(node:67143) Error: Invalid parameter: registrations
Registrations must be of type Registration[]
at handleResponse (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:477:48)
at processMessageQueue (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:292:17)
at Immediate.<anonymous> (/Users/nra76/Library/Application Support/Nova/Extensions/robb-j.yaml/node_modules/vscode-jsonrpc/lib/common/connection.js:276:13)
at processImmediate (internal/timers.js:464:21)
LSP startup messages
These are from a hacky script I made to visualise stdin/out of Nova's LSP integration, to be similar to VSCode's trace option.
The text was updated successfully, but these errors were encountered:
robb-j
changed the title
Unhandled promise rejects with dynamicRegistration disabled
Unhandled Promise rejections with dynamicRegistration disabled
Jun 25, 2021
Describe the bug
I've been adding yaml-language-server to Nova.app, this makes writing and managing YAML so much easier, thank you! Nova doesn't support dynamicRegistration and it is causing two Unhandled promise rejections as of
0.20.0
.The first seems to be
vscode-languageclient-node#713
, which is due to be fixed in the upcoming7.1
release.I think the second unhandled rejection is coming from here:
https://github.com/redhat-developer/yaml-language-server/blob/0.20.0/src/languageserver/handlers/settingsHandlers.ts#L23-L29
Should this line include a check for
clientDynamicRegisterSupport
?I've been tracking this locally at robb-j/nova-yaml#4
Expected Behavior
It shouldn't have any unhandled promise rejections, in Node 15+ they will cause the process to exit.
Current Behavior
Error messages
LSP startup messages
These are from a hacky script I made to visualise stdin/out of Nova's LSP integration, to be similar to VSCode's trace option.
Steps to Reproduce
Environment
The text was updated successfully, but these errors were encountered: