Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: i.startsWith is not a function #747

Closed
fbricon opened this issue Jul 8, 2022 · 2 comments · Fixed by #750
Closed

TypeError: i.startsWith is not a function #747

fbricon opened this issue Jul 8, 2022 · 2 comments · Fixed by #750
Labels
bug
Milestone
1.10.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Jul 8, 2022 •
edited
Loading

Describe the bug

Telemetry data shows a high number (>50% of all errors) of "TypeError: i.startsWith is not a function" errors on textDocument/hover and completion requests apparently

Expected Behavior

No error

Current Behavior

Errors are thrown:

TypeError: i.startsWith is not a function
    at /Users/_username_/.vscode/extensions/redhat.vscode-yaml-1.8.0/dist/languageserver.js:2:533672
    at T (/Users/_username_/.vscode/extensions/redhat.vscode-yaml-1.8.0/dist/languageserver.js:2:534665)
    at /Users/_username_/.vscode/extensions/redhat.vscode-yaml-1.8.0/dist/languageserver.js:2:523312
    at T (/Users/_username_/.vscode/extensions/redhat.vscode-yaml-1.8.0/dist/languageserver.js:2:525873)
    at f.getMatchingSchemas (/Users/_username_/.vscode/extensions/redhat.vscode-yaml-1.8.0/dist/languageserver.js:2:521654)
    at t.YamlCompletion.addPropertyCompletions (/Users/_username_/.vscode/extensions/redhat.vscode-yaml-1.8.0/dist/languageserver.js:2:560153)
    at t.YamlCompletion.<anonymous> (/Users/_username_/.vscode/extensions/redhat.vscode-yaml-1.8.0/dist/languageserver.js:2:558169)
    at Generator.next (<anonymous>)
    at s (/Users/_username_/.vscode/extensions/redhat.vscode-yaml-1.8.0/dist/languageserver.js:2:550676)

Steps to Reproduce

No idea
@fbricon fbricon added the bug label Jul 8, 2022
@fbricon fbricon changed the title "TypeError: i.startsWith is not a function" TypeError: i.startsWith is not a function Jul 8, 2022
@fbricon
Copy link
Contributor Author

fbricon commented Jul 8, 2022

This error started appearing with vscode-yaml 1.8.0

@msivasubramaniaan
Copy link
Contributor

This issue was resolved as part of the below ticket
redhat-developer/vscode-yaml#790

@msivasubramaniaan msivasubramaniaan added this to the 1.9.0 milestone Jul 13, 2022
@msivasubramaniaan msivasubramaniaan modified the milestones: 1.9.0, 1.10.0 Jul 20, 2022
@msivasubramaniaan msivasubramaniaan mentioned this issue Jul 20, 2022
Merged
@msivasubramaniaan msivasubramaniaan linked a pull request Jul 20, 2022 that will close this issue
check string type or not for value as well #750
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

check string type or not for value as well redhat-developer/yaml-language-server
2 participants
@fbricon @msivasubramaniaan