Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to configure plugins #228

Open
samof76 opened this issue Jun 25, 2020 · 8 comments
Open

Add an ability to configure plugins #228

samof76 opened this issue Jun 25, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@samof76
Copy link

samof76 commented Jun 25, 2020

How do i disable sematic-release plugins?

@samof76
Copy link
Author

samof76 commented Jun 25, 2020

I do not want the changelog file from getting created.

@mad-it
Copy link
Contributor

mad-it commented Jun 25, 2020

The whole point of this project is to have a Github action around semantic-release plugin.
What are you trying to achieve?

@merlinnot
Copy link
Contributor

I guess the ask is to still be able to release (push packages, tag, ...) but do not generate a changelog. So basically, if you look at our Readme, do "optionally, updates the CHANGELOG.md file based on the analyzed commits" instead of "updates the CHANGELOG.md file based on the analyzed commits".

@samof76
Copy link
Author

samof76 commented Jul 14, 2020

@mad-it I would want to have the releases but i do not want to create changelog file, this interferes if i am not using trunk-based rather use a two-branch model with master and next(prerelease barnch). I constant willl have to rebase changes from the master because of changelog updates.

@cadaroya
Copy link

cadaroya commented Sep 15, 2020

+1 to @samof76 's concern and +1 to @merlinnot 's explanation

I'd want to use this github action for doing production releases in some production branch. But the problem is I'll have to rebase the development branch (from production) every after production release just because of the bot's changelog commit.

Additionally, I don't want the bot polluting my commit history.

From what I've tested so far, it seems that the version of release is dependent on the bot's last commit (cmiiw, not sure about this one). Can we please make this optional? i.e maybe we can depend on existing tag instead?

cc: @mad-it

@merlinnot merlinnot changed the title Disable plugins Add an ability to configure plugins Nov 24, 2020
@merlinnot merlinnot added the enhancement New feature or request label Nov 24, 2020
@merlinnot
Copy link
Contributor

Hi! I have an updated on this one: we'll be working on a functionality to fully customize plugins, which will enable both disabling default and enabling additional plugins. While we can't commit to any specific date, we hope to get to it by the end of the year.

@acazacu
Copy link
Contributor

acazacu commented Dec 2, 2020

@cadaroya I have added a PR that removes allows for disabling generating or updating a CHANGELOG.md file, but even so, the action still commits several files by default if used with the node-module input set to true. Disabling this altogether would have users manually update the version number if they are to avoid conflicts on subsequent runs of the action.

I'm trying to grasp your exact use case, so that we may adequately improve the action's behaviour. Can you elaborate a bit on:

Additionally, I don't want the bot polluting my commit history.

Thank you!

@acazacu
Copy link
Contributor

acazacu commented Dec 4, 2020

Disabling CHANGELOG.md generation was merged as a mitigation to this issues described here. Further on, I am moving to enable configuring all plugins directly by passing a configuration file to the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants