-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of postprocessing #73
Comments
Hi @henhuy, thanks for the initiative!
Good to hear we can reuse them.
First impression: Looks great. I like the dependency handling.
Makes a lot of sense. Good to avoid pickling. Must ensure though that no additional information is lost that is hidden in the components.
Sounds good.
Great. Some postprocessing steps are specific to a certain facade class (e.g. some result about electric vehicles). Do you have an idea how to handle those? Postprocessing methods could be incorporated in the facade. Postprocessing could e.g. check the "type" attribute which is related to the facade classes via facades.TYPEMAP and call these methods. Have not thought it through, thoug. |
Here are my notes on oemoflex' results from earller this month:
TODOs
|
Hi @jnnr,
I revisited the postprocessing code, here my suggestions for refactoring the module:
get_losses
andsubtract_output_from_input
could be improved)run_postprocessing
could be refactored using my suggestion from https://gist.github.com/henhuy/2f94df3f80dd5c8b01c739218df9f82eIf we agree on refactoring, I would start by adding tests for postprocessing, so that we can guarantee results to be the same!
What do you think?
The text was updated successfully, but these errors were encountered: