Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost of logging and Chrono #27

Open
craff opened this issue Nov 21, 2017 · 1 comment
Open

Cost of logging and Chrono #27

craff opened this issue Nov 21, 2017 · 1 comment

Comments

@craff
Copy link
Collaborator

craff commented Nov 21, 2017

In function which are very frequently called, log and chrono can cost a lot.
If I uncomment the log in add_term and add_valu, the cost of log+chorno in Equiv and
Compare is a factor between 2 and 3.

we should create a binary "main.native" where this log/chrono on small function are disabled
(keeping still the main one like typing) and a main.debug with all log and chrono.

@craff
Copy link
Collaborator Author

craff commented Nov 21, 2017

This could be cleanly implemented having two functions per log and two functions Chrono.add_time,
the new one being inactive in main.native and active in main.debug.

We must make sure these function doing nothing are inlined and eliminated by OCaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant