Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkyBlock profiles are not added to be scanned from players #43

Open
robere2 opened this issue Nov 4, 2023 · 1 comment
Open

SkyBlock profiles are not added to be scanned from players #43

robere2 opened this issue Nov 4, 2023 · 1 comment
Labels
Good first issue Issues that may be a good introduction to the repository's codebase. Module: Schemas Issues pertaining to the @mcsb/schemas package. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Type: Bug Issues that are about something which isn't working as expected.

Comments

@robere2
Copy link
Owner

robere2 commented Nov 4, 2023

The players.json schema generator is supposed to add up to 15 SkyBlock profiles as a postprocessing step, but this doesn't appear to be working currently.
@robere2 robere2 added Type: Bug Issues that are about something which isn't working as expected. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Module: Schemas Issues pertaining to the @mcsb/schemas package. Good first issue Issues that may be a good introduction to the repository's codebase. labels Nov 4, 2023
@robere2
Copy link
Owner Author

robere2 commented Nov 4, 2023

This is done in the HypixelPlayer schema in schemas.ts, currently at line 237. The length of the skyblockProfilesToScan before and after the postprocessor are equal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Issues that may be a good introduction to the repository's codebase. Module: Schemas Issues pertaining to the @mcsb/schemas package. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Type: Bug Issues that are about something which isn't working as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robere2