Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema generator pattern recognition #53

Open
Tracked by #41
robere2 opened this issue Dec 3, 2023 · 0 comments
Open
Tracked by #41

Schema generator pattern recognition #53

robere2 opened this issue Dec 3, 2023 · 0 comments
Labels
Module: Schemas Issues pertaining to the @mcsb/schemas package. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Type: Enhancement Issues that are about a way in which the application can be improved.

Comments

@robere2
Copy link
Owner

robere2 commented Dec 3, 2023 •
edited

Inventory data from the Hypixel API is structured as a map of numerical string keys (the inventory slot IDs) to the data within the corresponding inventory slot. Due to the amount of configurations, and the number of slots available, we instead use patternProperties for these.

I'd like it if the schema generator was capable of automatically detecting inventory structures and replacing them with the pattern ^\d+$. The catch to this would be there are other number-only keys that we may not want to include in this pattern, such as days of the week. We could look for "layout" or "inventory" in the key name.
@robere2 robere2 mentioned this issue Dec 3, 2023
Closed
4 tasks
@robere2 robere2 changed the title Automatically detecting inventory structures and replacing them with the pattern ^\d+$. The catch to this would be there are other number-only keys that we wouldn't want to include in this pattern, such as days of the week. We'll could look for "layout" or "inventory" in the key name. Schema generator pattern recognition Dec 3, 2023
@robere2 robere2 added Type: Enhancement Issues that are about a way in which the application can be improved. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Module: Schemas Issues pertaining to the @mcsb/schemas package. labels Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module: Schemas Issues pertaining to the @mcsb/schemas package. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Type: Enhancement Issues that are about a way in which the application can be improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robere2