Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls-crypt-v2 hmac cookie: somewhat brittle #165

Open
reynir opened this issue Nov 23, 2023 · 0 comments
Open

tls-crypt-v2 hmac cookie: somewhat brittle #165

reynir opened this issue Nov 23, 2023 · 0 comments

Comments

@reynir
Copy link
Contributor

reynir commented Nov 23, 2023

The tls-crypt-v2 hmac cookie support in #158 works fine, but it is somewhat brittle. For the CONTROL_WKC_V1 packet it is important it arrives first before any subsequent CONTROL_V1 packets as the server will not know how to decrypt and authenticate them. We don't do any particular effort to ensure the CONTROL_WKC_V1 packet has arrived before sending any remaining CONTROL_V1 or ACK_V1 packets - which OpenVPN seems to do.

I'm not sure how much this affects the reliability. It would be nice to test this with (artificial) packet loss.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reynir