Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default Unicode normalization to NFC #147

Open
roedoejet opened this issue Mar 9, 2022 · 3 comments
Open

Change default Unicode normalization to NFC #147

roedoejet opened this issue Mar 9, 2022 · 3 comments
Assignees
@roedoejet
Labels
enhancement New feature or request

Comments

@roedoejet
Copy link
Owner

No description provided.

@roedoejet roedoejet self-assigned this Mar 9, 2022
@roedoejet roedoejet added the enhancement New feature or request label Mar 9, 2022
@roedoejet
Copy link
Owner Author

Currently default is NFD based on stale downstream requirement from ReadAlongs - but NFC generally renders better and should be used by default.

@joanise joanise mentioned this issue Mar 10, 2022
Merged
@joanise
Copy link
Collaborator

joanise commented Mar 11, 2022 •
edited
Loading

Just a thought: we could go through all the existing mappings that don't explicitly declare their norm-form, and explicitly declare them NFD if that's actually needed. Then, changing the default should not have unintended consequences.

Oh, boy, just checked, and there are 55 mappings that don't declare their norm_form. This will be a much bigger job than I imagined...

@joanise
Copy link
Collaborator

joanise commented Jun 16, 2022 •
edited
Loading

With the compose-norm PR #166 I just did, this might now be a safe things to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roedoejet roedoejet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roedoejet @joanise