Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better unit testing for generate mapping #295

Open
joanise opened this issue Oct 4, 2023 · 0 comments
Open

Implement better unit testing for generate mapping #295

joanise opened this issue Oct 4, 2023 · 0 comments

Comments

@joanise
Copy link
Collaborator

joanise commented Oct 4, 2023

The recent upgrade to Pydantic 2 broke g2p generate-mapping, but we don't have adequate unit testing and the bugs introduced were not caught. See #293 fixing that.

So we should implement more comprehensive tests for generate-mapping, including actually creating a generated mapping in CI and validating it, somehow. test_z_ is probably where that will have to go, since this test will modify the in-memory database contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant