Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str g2p does not work if the orthographic text is lower-cased. #329

Open
roedoejet opened this issue Mar 1, 2024 · 1 comment
Open

str g2p does not work if the orthographic text is lower-cased. #329

roedoejet opened this issue Mar 1, 2024 · 1 comment

Comments

@roedoejet
Copy link
Owner

I'm not totally sure if it's the right decision to uppercase everything before g2p, but it warrants a discussion.

@joanise
Copy link
Collaborator

joanise commented Mar 1, 2024

I suggest a round-trip test: take str input, do tolower and then toupper, do you get the same text back? If so, that's a helpful hint, although no guarantee it'll all be OK. Anything that doesn't come back the same is a red flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants