Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremes and WITH TOTALS support #12

Open
blide opened this issue Jan 20, 2017 · 3 comments
Open

Extremes and WITH TOTALS support #12

blide opened this issue Jan 20, 2017 · 3 comments

Comments

@blide
Copy link

blide commented Jan 20, 2017

Currently Iter.Scan() breaks on the first empty line and misses extremes and WITH TOTALS rows which separated from the main data by an empty line. https://clickhouse.yandex/reference_en.html#TabSeparated
I see 2 ways:

  1. Include additional data by default
  2. Add flag Iter.SetAdditionalData(bool)
@m1nor
Copy link
Contributor

m1nor commented Jan 29, 2017

I have no time to implement it right now, but pull requests are welcome, I'll leave this issue open.

@blide
Copy link
Author

blide commented Jan 29, 2017

@m1nor which way would you prefer?

@m1nor
Copy link
Contributor

m1nor commented Jan 31, 2017

I think explicit variant is preferable, let's add func (i *Iter) SetOptions(opt IterOptions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants