Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external: Restructure external cluster examples manifests #13932

Merged
merged 1 commit into from
Apr 26, 2024
Merged

external: Restructure external cluster examples manifests #13932

merged 1 commit into from
Apr 26, 2024

Conversation

smoshiur1237
Copy link
Contributor

@smoshiur1237 smoshiur1237 commented Mar 14, 2024 •
edited

This PR will add separate directory to handle the external manifest. All the files under examples are kept same, so that the CI and tests are not broken.
Resolves #12599

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@smoshiur1237 smoshiur1237 force-pushed the restucture-external-moshiur branch 2 times, most recently from ce8e5bb to c1d956b Compare March 14, 2024 08:25
@smoshiur1237
Copy link
Contributor Author

/cc @travisn @parth-gr
Please add your suggestion. I tried not to do any changes in manifests under examples, but created directory and moved all manifest for external cluster and added same namespace like rook-ceph.

@smoshiur1237 smoshiur1237 changed the title External: Restructure external cluster examples manifests external: Restructure external cluster examples manifests Mar 14, 2024
@parth-gr parth-gr requested a review from travisn March 14, 2024 15:42
parth-gr
parth-gr reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@parth-gr parth-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@travisn should we update documents to update the links, plus can we also segregate the 3 different storage in 3 different folders

@travisn
Copy link
Member

travisn commented Mar 18, 2024

@travisn should we update documents to update the links, plus can we also segregate the 3 different storage in 3 different folders

Let's just make this change for the external cluster scenario, and not other scenarios. And let's update the docs for the external cluster to use these examples. Since the goal is to improve the the external scenario with this change, the docs should tell the user about these new docs.

@mergify Mergify
Copy link

mergify bot commented Mar 28, 2024

This pull request has merge conflicts that must be resolved before it can be merged. @smoshiur1237 please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

@smoshiur1237
Copy link
Contributor Author

@parth-gr Does it looks good? Please review

@smoshiur1237 smoshiur1237 force-pushed the restucture-external-moshiur branch 5 times, most recently from b3898b4 to adf860a Compare April 4, 2024 10:55
@smoshiur1237 smoshiur1237 force-pushed the restucture-external-moshiur branch 2 times, most recently from db9aee6 to 00de2ac Compare April 17, 2024 13:30
@smoshiur1237 smoshiur1237 force-pushed the restucture-external-moshiur branch 2 times, most recently from 89e8579 to f7b0f5e Compare April 25, 2024 06:44
@smoshiur1237
Copy link
Contributor Author

@parth-gr @travisn I have changed the namespace to rook-ceph according to our discussion. Would you please do the final review?

@parth-gr
Copy link
Member

We can add symlinks for now and later in future and we can just keep the external cluster yamls only in external folder

parth-gr
parth-gr approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@parth-gr parth-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoshiur1237 smoshiur1237 force-pushed the restucture-external-moshiur branch 2 times, most recently from 63ebea1 to 25dedc3 Compare April 25, 2024 10:56
@smoshiur1237
external: restructure external cluster examples manifests
dab17f7 
This PR will add separate directory to handle the external manifest. Here external manifests will have same namespace (rook-ceph) for external cluster.

Signed-off-by: smoshiur1237 <[email protected]>
@smoshiur1237
Copy link
Contributor Author

smoshiur1237 commented Apr 26, 2024 •
edited

Noticed two nit in the external doc and updated the namespace. Otherwise all the contents are according to our discussion.

@travisn travisn merged commit 381556a into rook:master Apr 26, 2024
53 checks passed
@BlaineEXE
Copy link
Member

backporting to help markdownlint across all docs go more smoothly, without possible edge cases getting lost in the external docs

@mergify mergify bot mentioned this pull request May 1, 2024
Merged
6 tasks
BlaineEXE added a commit that referenced this pull request May 1, 2024
@BlaineEXE
Merge pull request #14148 from rook/mergify/bp/release-1.14/pr-13932
4005730 
external: Restructure external cluster examples manifests (backport #13932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@BlaineEXE BlaineEXE BlaineEXE approved these changes

@parth-gr parth-gr parth-gr approved these changes

Assignees
No one assigned
Labels
backport-release-1.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a seprate directory structure for external cluster examples manifests
4 participants
@smoshiur1237 @travisn @parth-gr @BlaineEXE