doc: make CSI host netowrking required #14023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The network providers doc, including the holder pod migration sections, were developed with the understanding that CSI could be placed into pod networking mode if desired by users. In reality, this hasn't been supported due to bugs. This allows streamlining the holder pod migration sections to no longer need to document for users what to do if they use CSI in pod network mode. Rook will continue to have the `CSI_ENABLE_HOST_NETWORK` config available as an undocumented value. This can allow users who desperately cannot use host networking to still use pod networking, though this will mean any CSI node plugin updates could stall mounts for running apps. Thus we do not support it. Signed-off-by: Blaine Gardner <[email protected]>
BlaineEXE
commented
Apr 3, 2024
| @@ -79,27 +79,6 @@ to or from host networking after you update this setting, you will need to | |||
| [failover the mons](../../Storage-Configuration/Advanced/ceph-mon-health.md#failing-over-a-monitor) | |||
| in order to have mons on the desired network configuration. | |||
|
|
|||
| ## CSI Host Networking | |||
There was a problem hiding this comment.
In an earlier version of my work, I kept this section but renamed it CSI Pod Networking (unsupported) and changed some of the first paragraph to reflect that it is an option but isn't supported. In editing, I decided to remove the section entirely. If we encounter many multus users who have issues with the prerequisites, we may want to discuss adding this section back and having some limited support (mostly, setting the plugin upgrade strategy to OnDelete) for the pod networking with multus as an alternative.
travisn
approved these changes
Apr 3, 2024
6 tasks
travisn
added a commit
that referenced
this pull request
Apr 4, 2024
doc: make CSI host netowrking required (backport #14023)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network providers doc, including the holder pod migration sections, were developed with the understanding that CSI could be placed into pod networking mode if desired by users. In reality, this hasn't been supported due to bugs.
This allows streamlining the holder pod migration sections to no longer need to document for users what to do if they use CSI in pod network mode.
Rook will continue to have the
CSI_ENABLE_HOST_NETWORKconfig available as an undocumented value. This can allow users who desperately cannot use host networking to still use pod networking, though this will mean any CSI node plugin updates could stall mounts for running apps. Thus we do not support it.Checklist: