Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi: create csi configmap if csi controller is disabled #14125

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

parth-gr
Copy link
Member

Creating a cluster never succeeds if CSI driver is disabled So to fix that we need to always create the csi configmap

closes: #14123

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@parth-gr
Copy link
Member Author

Testing
Before fix

2024-04-24 11:36:17.894810 E | ceph-cluster-controller: failed to reconcile CephCluster "rook-ceph/my-cluster". failed to reconcile cluster "my-cluster": failed to configure local ceph cluster: failed to create cluster: failed to start ceph monitors: failed to initialize ceph cluster info: failed to save mons: failed to update csi cluster config: waiting for CSI config map to be created: configmaps "rook-ceph-csi-config" not found

After fix:

2024-04-24 11:40:14.084815 I | op-mon: saved mon endpoints to config map map[csi-cluster-config-json:[{"clusterID":"rook-ceph","monitors":["10.110.93.212:6789"],"cephFS":{"netNamespaceFilePath":"","subvolumeGroup":"","kernelMountOptions":"","fuseMountOptions":""},"rbd":{"netNamespaceFilePath":"","radosNamespace":""},"nfs":{"netNamespaceFilePath":""},"readAffinity":{"enabled":false,"crushLocationLabels":null},"namespace":""}] data:a=10.110.93.212:6789 mapping:{"node":{"a":{"Name":"minikube","Hostname":"minikube","Address":"192.168.39.204"}}} maxMonId:0 outOfQuorum:]

Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, https://github.com/parth-gr/rook/blob/2e7398592498b0c9df184f41445190bcf76f8f83/pkg/operator/ceph/csi/cluster_config.go#L259 will be logged many times when the controller reconciles even if the csi is disabled, we can do logging only when create.

Creating a cluster never succeeds if CSI driver is disabled
So to fix that we need to always create the csi configmap

closes: rook#14123

Signed-off-by: parth-gr <[email protected]>
@parth-gr
Copy link
Member Author

parth-gr commented Apr 24, 2024

LGTM, https://github.com/parth-gr/rook/blob/2e7398592498b0c9df184f41445190bcf76f8f83/pkg/operator/ceph/csi/cluster_config.go#L259 will be logged many times when the controller reconciles even if the csi is disabled, we can do logging only when create.

updated, Thanks!

@parth-gr parth-gr requested a review from Madhu-1 April 24, 2024 12:36
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travisn travisn merged commit e161cda into rook:master Apr 24, 2024
53 checks passed
mergify bot added a commit that referenced this pull request Apr 24, 2024
csi: create csi configmap if csi controller is disabled (backport #14125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a cluster never succeeds if CSI driver is disabled
3 participants