-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csi: create csi configmap if csi controller is disabled #14125
Conversation
Testing
After fix:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, https://github.com/parth-gr/rook/blob/2e7398592498b0c9df184f41445190bcf76f8f83/pkg/operator/ceph/csi/cluster_config.go#L259 will be logged many times when the controller reconciles even if the csi is disabled, we can do logging only when create.
Creating a cluster never succeeds if CSI driver is disabled So to fix that we need to always create the csi configmap closes: rook#14123 Signed-off-by: parth-gr <[email protected]>
f92580c
to
47ed6a8
Compare
updated, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csi: create csi configmap if csi controller is disabled (backport #14125)
Creating a cluster never succeeds if CSI driver is disabled So to fix that we need to always create the csi configmap
closes: #14123
Checklist: